Skip to content

Conversation

haroldbruintjes
Copy link

The condition for is_terminated in the FusedStream impl for Zip should check if either child stream has terminated. Otherwise, one stream may be polled even after it has been terminated if the other has not.

This following example triggers the current bug:

use futures::stream::{self, StreamExt};

#[tokio::main]
pub async fn main() {
    let stream1 = stream::iter(vec![17, 19]);
    let stream2 = stream::iter(vec![17]);
    let mut zipped = stream1.zip(stream2);
    loop {
        futures::select!{
            res = zipped.select_next_some() => {
                println!("Zip result {res:?}");
            }
            complete => break,
        }
        
    }
}

The condition for `is_terminated` in the `FusedStream` impl for `Zip` should check if either child stream has terminated. Otherwise, one stream may be polled even after it has been terminated if the other has not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant